This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Neels Hofmeyr nhofmeyr at sysmocom.deOn Mon, Nov 16, 2015 at 04:06:44PM +0100, Andreas Schultz wrote:
> This add basic network namespace support by changing to global
> gtp_instance_list into a pre namespace list.
Just a hair splitting style remark ... from my ASF days I've adopted the
nice, short and simple way of writing comments and log messages, which is
to basically use imperatives without naming subjects, all the time:
"Add foo. Return bar. Implement baz."
(not "This adds foo" or "This function returns bar", etc.)
It always makes things shorter and easier to edit, because it loses all
the verb suffixes ("add", not "adds").
I'm writing this mainly because following this style helped me a lot, not
trying to impose it on others -- carry on, no problems here ;)
That said, above log message has English errors:
> This add basic network namespace support
"adds"
> by changing to global gtp_instance_list into a pre namespace list.
A "to" too many? Is "pre namespace list" something I don't know or could
it be described more clearly?
> all pdp context
"contexts"
> now only the namespace that they belong too, can see them.
"...belong to can see them" (lose an o and the comma)
I'm sorry to review the log message and omit the code, but I'm juust out
of time for now. More will follow.
~Neels
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20151117/9a2accf0/attachment.bin>