[PATCH 5/5] stats: Add TODO comment to rate_ctr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Tue Nov 17 12:18:25 UTC 2015


Currently the counters are scanned twice, once for interval
computation and once for reporting.

This adds a reminder to move the interval computation code to a
special stats reporter which just updates the fields.

Sponsored-by: On-Waves ehf
---
 src/rate_ctr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/rate_ctr.c b/src/rate_ctr.c
index 50b3fe7..436deef 100644
--- a/src/rate_ctr.c
+++ b/src/rate_ctr.c
@@ -92,6 +92,9 @@ int64_t rate_ctr_difference(struct rate_ctr *ctr)
 	return result;
 }
 
+/* TODO: support update intervals > 1s */
+/* TODO: implement this as a special stats reporter */
+
 static void interval_expired(struct rate_ctr *ctr, enum rate_ctr_intv intv)
 {
 	/* calculate rate over last interval */
-- 
1.9.1




More information about the OpenBSC mailing list