libosmocore minor issues

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Thu Nov 12 12:50:40 UTC 2015


Hi Jaroslav,

On Wed, Nov 11, 2015 at 10:23:11AM -0500, Jaroslav Skarvada wrote:
> > > During the packaging I found following minor issues:
> > > - Incorrect FSF addresses in source code
> > 
> Patch attempting to fix it is attached.

Patch applied, thanks.

> > > - exit call in the library: /usr/lib64/libosmovty.so.3.0.0 exit at GLIBC_2.2.5
> > > libraries shouldn't generally call exit.
> > 
> > So the best we can do without breaking API and ABI (and modifying all
> > users of the library) is to change the exit(1) calls into an assert.
> > Would that be better?
> 
> Nice, thanks. Please note, this is not something that blocks Fedora
> review, I just wanted to point it out, e.g. to consider it for
> next API update sometimes in the future

Thanks.  I've just applied a patch to change the exit() calls into
OSMO_ASSERT() instead, which is a better and more generic way to do this
anyway.

The VTY code doesn't get much love from us, we simply adapted it from
Zebra back in the early days of OpenBSC, and it sits there without much
review/improvement/change.

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list