libosmocore minor issues

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Tue Nov 10 19:48:40 UTC 2015


Hi Jaroslav,

On Tue, Nov 10, 2015 at 04:56:23AM -0500, Jaroslav Skarvada wrote:
> I am working on getting libosmocom package into Fedora, there is
> review request in [1].

Thanks for this!
 
> During the packaging I found following minor issues:
> - Incorrect FSF addresses in source code

This is easy to fix.  Do you already have a patch to fix all
occurrences?  I'd happily apply that.

> - exit call in the library: /usr/lib64/libosmovty.so.3.0.0 exit at GLIBC_2.2.5
> libraries shouldn't generally call exit.

libosmovty started as a fork of the VTY (telnet command line interface)
code of GNU zebra.  So the code was not written as a library to begin
with, but was part of zebra itself.

In any case, addressing those issues is not particularly easy, as said
functions should never fail at this point, but they don't have a way to
return an error code, or their callers simply assume they always
succeed.

So the best we can do without breaking API and ABI (and modifying all
users of the library) is to change the exit(1) calls into an assert.
Would that be better?

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list