[PATCH 5/6] gsup/oap: add OAP to GSUP client.

[Neels Hofmeyr]

On Mon, Nov 02, 2015 at 11:33:50AM +0100, Holger Freyther wrote:
> > static int gsup_client_read_cb(struct ipa_client_conn *link, struct msgb *msg)
> > {
> > 
> > -	OSMO_ASSERT(gsupc->read_cb != NULL);
> > -	gsupc->read_cb(gsupc, msg);
> > +	if (he->proto == IPAC_PROTO_EXT_GSUP) {
> > +		OSMO_ASSERT(gsupc->read_cb != NULL);
> > +		gsupc->read_cb(gsupc, msg);
> > +		/* expecting read_cb() to free msg */
> > +	}
> > +	else
> > +	if (he->proto == IPAC_PROTO_EXT_OAP) {
> > +		return gsup_client_oap_handle(gsupc, msg);
> > +		/* gsup_client_oap_handle frees msg */
> > +	}
> > +	else
> > +		goto invalid;
> 
> the coding style would not have else and if on two different lines. I will fix this myself
> right now.

Yes, indeed. I'm doing that on purpose... the logical idea is that the if
conditions all start on the same column.

That's my personal dialect where I'm puzzled that no-one else seems to do
it this way. IMHO it's the only way to do it nicely ;)

that said ... do I really have to lose that bit of personal dialect?

Admitted, in a bunch of code where I'm editing, I should always adhere to
the local style. But my question is also for the gtphub development. Sure
it's nice to have all styles match in osmo code ... I guess I need someone
to push me to write "else if" on the same line. Against the styles in
openggsn, this style deviation is harmless ... right?? ;)

~Neels

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20151102/26173579/attachment.bin>