[PATCH] opensgsn: Replace some TODOs with error paths and fix compiler warning

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Mike McTernan (wavemobile) mike.mcternan at wavemobile.com
Fri May 1 08:35:08 UTC 2015


Hi Holger,

Sorry about this - I know you are busy.

> Which version of OpenGGSN are you using? Where did you check it out?
> What is the last git commit? I ask because the patch does not apply and the
> line numbers in tun.c are quite different.

That's odd.  I've cloned from git.osmocom.org.  Just taking a fresh tree, it applies cleanly here: 

$ git clone git://git.osmocom.org/openggsn.git
Cloning into 'openggsn'...
remote: Counting objects: 1401, done.
remote: Compressing objects: 100% (530/530), done.
remote: Total 1401 (delta 990), reused 1194 (delta 850)
Receiving objects: 100% (1401/1401), 887.13 KiB | 1.58 MiB/s, done.
Resolving deltas: 100% (990/990), done.
$ cd openggsn
$ git apply -p2 ../../osmobss/patches/Check-and-fix-tun-setup-error-paths-v2.patch
$ git status
# On branch master
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       modified:   lib/tun.c
#
no changes added to commit (use "git add" and/or "git commit -a")

One thing I should probably have mentioned is that it needs -p2 since I'm using quilt to manage patch sets across the various libosmo*, openbsc, openggsn, bts etc... so it's one dir up.

Did I do something wrong in the above?

Kind Regards,

Mike



More information about the OpenBSC mailing list