[PATCH 2/3] bssgp: Don't reply with STATUS when receiving a PtP STATUS message

Jacob Erlbeck jerlbeck at sysmocom.de
Tue Mar 17 09:21:16 UTC 2015


Currently each incoming PtP BSSGP STATUS message is handled as 'not
yet implemented' and a BSSGP STATUS message (cause
BSSGP_CAUSE_PROTO_ERR_UNSPEC) is sent back to the peer. This will
cause endless messages loops if both peers use this BSSGP stack
implementation. This does not apply to signalling messages.

This commit changes the implementation of bssgp_rx_ptp() to just do
logging in this case.

Sponsored-by: On-Waves ehf
---
 src/gb/gprs_bssgp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index 851d01c..8708340 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -845,7 +845,9 @@ static int bssgp_rx_ptp(struct msgb *msg, struct tlv_parsed *tp,
 		break;
 	case BSSGP_PDUT_STATUS:
 		/* Some exception has occurred */
+		DEBUGP(DBSSGP, "BSSGP BVCI=%u Rx PTP BVC STATUS\n", bctx->bvci);
 		/* FIXME: send NM_STATUS.ind to NM */
+		break;
 	case BSSGP_PDUT_DOWNLOAD_BSS_PFC:
 	case BSSGP_PDUT_CREATE_BSS_PFC_ACK:
 	case BSSGP_PDUT_CREATE_BSS_PFC_NACK:
-- 
1.9.1




More information about the OpenBSC mailing list