[PATCH] bssgp: Fix IMSI buffer size (Coverity)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Fri Jun 19 18:56:14 UTC 2015


> On 18 Jun 2015, at 13:21, Jacob Erlbeck <jerlbeck at sysmocom.de> wrote:
> 
> Currently the size of the IMSI pointer is used instead of the size of
> the talloc'ed buffer.
> 
> This commit changes the call to gsm48_mi_to_string to use the same
> value that has been used with talloc_zero_size(). The length is
> changed to 17 since that value is used for GSM_IMSI_LENGTH in
> openbsc.

Thank you. It feels good to close the amount of open coverity issues. Could
you identify a good place to put the IMSI_LENGTH/MSISDN_LENGTH in a
header file of libosmogsm? I think we have two definitions in OpenBSC now
and one in libosmocore.

have a nice weekend
	holger



More information about the OpenBSC mailing list