[PATCH 4/4] build: avoid spurious hard dependency on libosmo-sccp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Andreas Rottmann mail at rotty.xx.vu
Tue Jun 16 21:23:31 UTC 2015


From: Andreas Rottmann <a.rottmann at gmx.at>

In the libfilter source code, which is built regardless of --enable-nat,
headers from libosmo-sccp were used, thus causing a build failure (see
below) when building without --enable-nat, and libosmo-sccp not being
installed (or being installed in a prefix not otherwise included in the
build).

The build fails like this:

In file included from ../../../src/libfilter/bsc_msg_filter.c:27:0:
../../../include/openbsc/bsc_nat_sccp.h:27:37: fatal error: osmocom/sccp/sccp_types.h: No such file or directory

As the includes seem not to be actually needed, this change fixes the
issue by just omitting them.
---
 openbsc/src/libfilter/bsc_msg_filter.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/openbsc/src/libfilter/bsc_msg_filter.c b/openbsc/src/libfilter/bsc_msg_filter.c
index be518a4..eafeff4 100644
--- a/openbsc/src/libfilter/bsc_msg_filter.c
+++ b/openbsc/src/libfilter/bsc_msg_filter.c
@@ -24,7 +24,6 @@
 #include <openbsc/bsc_msg_filter.h>
 
 #include <openbsc/bsc_nat.h>
-#include <openbsc/bsc_nat_sccp.h>
 #include <openbsc/bsc_msc.h>
 #include <openbsc/gsm_data.h>
 #include <openbsc/debug.h>
@@ -36,8 +35,6 @@
 #include <osmocom/gsm/protocol/gsm_08_08.h>
 #include <osmocom/gsm/protocol/gsm_04_11.h>
 
-#include <osmocom/sccp/sccp.h>
-
 int bsc_filter_barr_find(struct rb_root *root, const char *imsi, int *cm, int *lu)
 {
 	struct bsc_filter_barr_entry *n;
-- 
2.1.4




More information about the OpenBSC mailing list