[PATCH 2/4] sms: Put the try_deliver into the header file

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peyer Freyther holger at freyther.de
Mon Jul 6 14:52:28 UTC 2015


From: Holger Hans Peter Freyther <holger at moiji-mobile.com>

Even if it is using BSC/NITB types let's put it in the header
file than just declaring it at a place that could bitrot in a
way that doesn't lead a warning.
---
 openbsc/src/libmsc/gsm_04_11.c | 2 --
 openbsc/src/libmsc/smpp_smsc.h | 8 ++++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c
index 0150de6..82e9fae 100644
--- a/openbsc/src/libmsc/gsm_04_11.c
+++ b/openbsc/src/libmsc/gsm_04_11.c
@@ -57,8 +57,6 @@
 
 #ifdef BUILD_SMPP
 #include "smpp_smsc.h"
-extern int smpp_try_deliver(struct gsm_sms *sms,
-			    struct gsm_subscriber_connection *conn);
 #endif
 
 void *tall_gsms_ctx;
diff --git a/openbsc/src/libmsc/smpp_smsc.h b/openbsc/src/libmsc/smpp_smsc.h
index 21d28dd..8d31b2b 100644
--- a/openbsc/src/libmsc/smpp_smsc.h
+++ b/openbsc/src/libmsc/smpp_smsc.h
@@ -131,4 +131,12 @@ int smpp_route_pfx_del(struct osmo_smpp_acl *acl,
 int smpp_vty_init(void);
 
 int smpp_determine_scheme(uint8_t dcs, uint8_t *data_coding, int *mode);
+
+
+
+struct gsm_sms;
+struct gsm_subscriber_connection;
+
+int smpp_try_deliver(struct gsm_sms *sms,
+			    struct gsm_subscriber_connection *conn);
 #endif
-- 
2.3.5




More information about the OpenBSC mailing list