[PATCH] Fix some recently added formats on 64bit

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Wed Dec 23 14:12:40 UTC 2015


86ec311896dd5d4 adds compiler warnings on 64bit. The build is clean otherwise,
so let's keep it that way.
---
 src/msgb.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/msgb.c b/src/msgb.c
index 4b108a4..6361913 100644
--- a/src/msgb.c
+++ b/src/msgb.c
@@ -28,6 +28,7 @@
 #include <unistd.h>
 #include <string.h>
 #include <stdlib.h>
+#include <inttypes.h>
 
 #include <osmocom/core/msgb.h>
 //#include <openbsc/gsm_data.h>
@@ -274,14 +275,15 @@ const char *msgb_hexdump(const struct msgb *msg)
 			continue;
 		if (lxhs[i] < msg->data || lxhs[i] > msg->tail) {
 			nchars = snprintf(buf + buf_offs, sizeof(buf) - buf_offs,
-					  "(L%d=data%+d) ",
+					  "(L%d=data%+" PRIdPTR ") ",
 					  i+1, lxhs[i] - msg->data);
 			buf_offs += nchars;
 			continue;
 		}
 		if (lxhs[i] < start) {
 			nchars = snprintf(buf + buf_offs, sizeof(buf) - buf_offs,
-					  "(L%d%+d) ", i+1, start - lxhs[i]);
+					  "(L%d%+" PRIdPTR ") ", i+1,
+					  start - lxhs[i]);
 			buf_offs += nchars;
 			continue;
 		}
@@ -312,7 +314,7 @@ const char *msgb_hexdump(const struct msgb *msg)
 		} else if (lxhs[i] <= msg->data + msg->data_len &&
 			   lxhs[i] > msg->tail) {
 			nchars = snprintf(buf + buf_offs, sizeof(buf) - buf_offs,
-					  "(L%d=tail%+d) ",
+					  "(L%d=tail%+" PRIdPTR ") ",
 					  i+1, lxhs[i] - msg->tail);
 		} else
 			continue;
-- 
2.1.4




More information about the OpenBSC mailing list