[PATCH 5/5] build: remove bundled copy of talloc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Sat Oct 4 09:59:56 UTC 2014


On Sat, Oct 04, 2014 at 11:10:25AM +0200, Jan Engelhardt wrote:

> diff --git a/include/osmocom/core/talloc.h.in b/include/osmocom/core/talloc.h.in
> deleted file mode 100644
> index edbbb63..0000000
> --- a/include/osmocom/core/talloc.h.in
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -#pragma once
> -#if @OSMOCORE_INTERNAL_TALLOC@
> -#include <osmocom/core/talloc_int.h>
> -#else
> -#include <talloc.h>
> -#endif

leave it for a transition period.

> --- a/include/osmocom/ctrl/control_cmd.h
> +++ b/include/osmocom/ctrl/control_cmd.h
> @@ -1,7 +1,7 @@
>  #pragma once
>  
>  #include <osmocom/core/msgb.h>
> -#include <osmocom/core/talloc.h>
> +#include <talloc.h>
>  #include <osmocom/core/write_queue.h>
>  #include <osmocom/core/logging.h>

In general these blocks are grouped. E.g. from most specific to
general (specially to make sure that a header file can be included
directly). So all of the #include <talloc.h> are at the wrong place
now. Either it is done correctly right now or leave osmocom/core/talloc.h
for a transition period.


thanks for working on it
	holger





More information about the OpenBSC mailing list