This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Jan Engelhardt jengelh at inai.deOn Friday 2014-10-03 14:20, Peter Stuge wrote: >Jan Engelhardt wrote: >> >* Firmware builds with no talloc >> >> That may be the use case, but it is not what was implemented. > >Why don't you look into fixing that Why should I? Why can't you? >> If you build 0.7.0 [336915aa0a] with --disable-talloc, `ldd >> src/.libs/libosmocore.so` will show libtalloc.so.2. > >Do you want to investigate why? Because someone placed -ltalloc into libosmocore_la_LIBADD, the result of satisfying the calls to talloc that the osmocore code is sprinkled with. IOW, osmocore provides no alternative paths to using talloc. >> >> +++ b/tests/msgfile/msgfile_test.c >> >> @@ -20,6 +20,7 @@ >> >> */ >> >> >> >> #include <osmocom/core/msgfile.h> >> >> +#include <osmocom/core/talloc.h> >> > >> >Is this hunk needed? >> >> Yes, because system talloc has a >> >> #define talloc_free(ctx) _talloc_free(ctx, __location__) >> >> and otherwise, one gets "implicit definition of talloc_free" and >> "undefined reference to `talloc_free'". > >Dude, that is a kludge at a callsite, as opposed to a proper >dependency fix. Try again. Well, enlighten us, mr-know-it-all.