[PATCH] Configure the auth token sms text in the database

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Thu Nov 20 22:59:54 UTC 2014


On Sat, Nov 15, 2014 at 02:03:31PM -0600, Ruben Pollan wrote:
> Good morning,

Good Evening!

> You are right, this is not great. After discussing it with ciaby we decided that 
> might make more sense to do something like:
> 
> snprintf(sms_str, len, "%s IMSI: %s Token: %08X Ext: %s"
> 		 auth_token_sms_text, subscr->imsi, token, subscr->extension);
> 
> So the auth_token_sms_text don't have any placeholders it's just the 
> introductory text. What do you think?

Yes, it would be missing i18n.. but so does the entire OpenBSC
codebase. I would really prefer to set this through the VTY than
to put it into a database. Using ".TEXT" inside the VTY command
string you can match more than just a single word. I think '%'
is still not possible though.


holger




More information about the OpenBSC mailing list