[PATCH] Configure the auth token sms text in the database

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Ruben Pollan meskio at sindominio.net
Sat Nov 15 20:03:31 UTC 2014


Good morning,

Quoting Holger Hans Peter Freyther (2014-11-15 03:11:46)
> why does this need to go into the DB and not the configuration
> file? 

Our first attempt was to do it in the configuration file, but we realized that 
vty doesn't have support for strings with spaces. Or did we miss something?

We decided that was easier to add it to the database than to extend vty to parse 
strings with " or other way to support spaces.

> What is your stand on checking the configured string for
> the right amount of printf placeholders?

You are right, this is not great. After discussing it with ciaby we decided that 
might make more sense to do something like:

snprintf(sms_str, len, "%s IMSI: %s Token: %08X Ext: %s"
		 auth_token_sms_text, subscr->imsi, token, subscr->extension);

So the auth_token_sms_text don't have any placeholders it's just the 
introductory text. What do you think?


-- 
Ruben Pollan  | http://meskio.net/
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 My contact info: http://meskio.net/crypto.txt
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Nos vamos a Croatan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20141115/8d397e9b/attachment.bin>


More information about the OpenBSC mailing list