[PATCH 2/2] gsm0411_smr: Fix the size of the array

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Fri May 23 06:54:58 UTC 2014


From: Holger Hans Peter Freyther <holger at moiji-mobile.com>

The code is lacking a "," at the end of a string and we ended up
doing string concatination instead of having an invalid state.

Fixes Coverity CID 1206564
---
 src/gsm/gsm0411_smr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gsm/gsm0411_smr.c b/src/gsm/gsm0411_smr.c
index a7e9d24..eb1f036 100644
--- a/src/gsm/gsm0411_smr.c
+++ b/src/gsm/gsm0411_smr.c
@@ -97,7 +97,7 @@ void gsm411_smr_clear(struct gsm411_smr_inst *inst)
 static const char *smr_state_names[] = {
 	"IDLE",
 	"WAIT_FOR_RP_ACK",
-	"illegal state 2"
+	"illegal state 2",
 	"WAIT_TO_TX_RP_ACK",
 	"WAIT_FOR_RETRANS_T",
 };
-- 
1.9.1





More information about the OpenBSC mailing list