[PATCH 10/11] mgcp: Move transcoding to libmgcp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Thu May 15 08:29:18 UTC 2014 

This patch moves the files relevant to transcoding from
src/osmo-bsc_mgcp to src/libmgcp and src/include/openbsc. Makefiles
and include directives are being updated accordingly.

Sponsored-by: On-Waves ehf
---
 openbsc/contrib/testconv/Makefile                  |    3 +--
 openbsc/contrib/testconv/testconv_main.c           |    2 +-
 openbsc/include/openbsc/Makefile.am                |    3 ++-
 .../openbsc}/mgcp_transcode.h                      |    0
 openbsc/src/libmgcp/Makefile.am                    |   12 ++++++++++--
 .../src/{osmo-bsc_mgcp => libmgcp}/g711common.h    |    0
 .../{osmo-bsc_mgcp => libmgcp}/mgcp_transcode.c    |    0
 openbsc/src/osmo-bsc_mgcp/Makefile.am              |    9 ++-------
 openbsc/src/osmo-bsc_mgcp/mgcp_main.c              |    2 +-
 openbsc/tests/mgcp/Makefile.am                     |    2 +-
 openbsc/tests/mgcp/mgcp_transcoding_test.c         |    2 +-
 11 files changed, 19 insertions(+), 16 deletions(-)
 rename openbsc/{src/osmo-bsc_mgcp => include/openbsc}/mgcp_transcode.h (100%)
 rename openbsc/src/{osmo-bsc_mgcp => libmgcp}/g711common.h (100%)
 rename openbsc/src/{osmo-bsc_mgcp => libmgcp}/mgcp_transcode.c (100%)

diff --git a/openbsc/contrib/testconv/Makefile b/openbsc/contrib/testconv/Makefile
index 90adecc..bb856f7 100644
--- a/openbsc/contrib/testconv/Makefile
+++ b/openbsc/contrib/testconv/Makefile
@@ -1,5 +1,5 @@
 
-OBJS = testconv_main.o mgcp_transcode.o
+OBJS = testconv_main.o
 
 CC = gcc
 CFLAGS = -O0 -ggdb -Wall
@@ -11,7 +11,6 @@ testconv: $(OBJS)
 	$(CC)  -o $@ $^ $(LDFLAGS) $(LIBS)
 
 testconv_main.o: testconv_main.c
-mgcp_transcode.o: ../../src/osmo-bsc_mgcp/mgcp_transcode.c
 
 $(OBJS):
 	$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<
diff --git a/openbsc/contrib/testconv/testconv_main.c b/openbsc/contrib/testconv/testconv_main.c
index e74c686..89dce1a 100644
--- a/openbsc/contrib/testconv/testconv_main.c
+++ b/openbsc/contrib/testconv/testconv_main.c
@@ -17,7 +17,7 @@
 #error "Requires MGCP transcoding enabled (see --enable-mgcp-transcoding)"
 #endif
 
-#include "src/osmo-bsc_mgcp/mgcp_transcode.h"
+#include "openbsc/mgcp_transcode.h"
 
 static int audio_name_to_type(const char *name)
 {
diff --git a/openbsc/include/openbsc/Makefile.am b/openbsc/include/openbsc/Makefile.am
index 8f7c1c4..6b08d07 100644
--- a/openbsc/include/openbsc/Makefile.am
+++ b/openbsc/include/openbsc/Makefile.am
@@ -13,7 +13,8 @@ noinst_HEADERS = abis_nm.h abis_rsl.h db.h gsm_04_08.h gsm_data.h \
 		osmo_bsc_rf.h osmo_bsc.h network_listen.h bsc_nat_sccp.h \
 		osmo_msc_data.h osmo_bsc_grace.h sms_queue.h abis_om2000.h \
 		bss.h gsm_data_shared.h control_cmd.h ipaccess.h mncc_int.h \
-		arfcn_range_encode.h nat_rewrite_trie.h bsc_nat_callstats.h
+		arfcn_range_encode.h nat_rewrite_trie.h bsc_nat_callstats.h \
+		mgcp_transcode.h
 
 openbsc_HEADERS = gsm_04_08.h meas_rep.h bsc_api.h
 openbscdir = $(includedir)/openbsc
diff --git a/openbsc/src/osmo-bsc_mgcp/mgcp_transcode.h b/openbsc/include/openbsc/mgcp_transcode.h
similarity index 100%
rename from openbsc/src/osmo-bsc_mgcp/mgcp_transcode.h
rename to openbsc/include/openbsc/mgcp_transcode.h
diff --git a/openbsc/src/libmgcp/Makefile.am b/openbsc/src/libmgcp/Makefile.am
index 72f625d..bd02e61 100644
--- a/openbsc/src/libmgcp/Makefile.am
+++ b/openbsc/src/libmgcp/Makefile.am
@@ -1,7 +1,15 @@
 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
-AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS)
-AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(COVERAGE_LDFLAGS)
+AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS) \
+	$(LIBBCG729_CFLAGS)
+AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(COVERAGE_LDFLAGS) \
+	$(LIBBCG729_LIBS)
 
 noinst_LIBRARIES = libmgcp.a
 
+noinst_HEADERS = g711common.h
+
 libmgcp_a_SOURCES = mgcp_protocol.c mgcp_network.c mgcp_vty.c
+
+if BUILD_MGCP_TRANSCODING
+    libmgcp_a_SOURCES += mgcp_transcode.c
+endif
diff --git a/openbsc/src/osmo-bsc_mgcp/g711common.h b/openbsc/src/libmgcp/g711common.h
similarity index 100%
rename from openbsc/src/osmo-bsc_mgcp/g711common.h
rename to openbsc/src/libmgcp/g711common.h
diff --git a/openbsc/src/osmo-bsc_mgcp/mgcp_transcode.c b/openbsc/src/libmgcp/mgcp_transcode.c
similarity index 100%
rename from openbsc/src/osmo-bsc_mgcp/mgcp_transcode.c
rename to openbsc/src/libmgcp/mgcp_transcode.c
diff --git a/openbsc/src/osmo-bsc_mgcp/Makefile.am b/openbsc/src/osmo-bsc_mgcp/Makefile.am
index a620e7a..da02380 100644
--- a/openbsc/src/osmo-bsc_mgcp/Makefile.am
+++ b/openbsc/src/osmo-bsc_mgcp/Makefile.am
@@ -1,16 +1,11 @@
 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
 AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) \
-	$(LIBOSMOVTY_CFLAGS) $(LIBOSMOABIS_CFLAGS) $(COVERAGE_CFLAGS) \
-	$(LIBBCG729_CFLAGS)
+	$(LIBOSMOVTY_CFLAGS) $(LIBOSMOABIS_CFLAGS) $(COVERAGE_CFLAGS)
 
 bin_PROGRAMS = osmo-bsc_mgcp
 
 osmo_bsc_mgcp_SOURCES = mgcp_main.c
-if BUILD_MGCP_TRANSCODING
-    osmo_bsc_mgcp_SOURCES += mgcp_transcode.c
-endif
+
 osmo_bsc_mgcp_LDADD = $(top_builddir)/src/libcommon/libcommon.a \
 		 $(top_builddir)/src/libmgcp/libmgcp.a -lrt \
 		 $(LIBOSMOVTY_LIBS) $(LIBOSMOCORE_LIBS) $(LIBBCG729_LIBS)
-
-noinst_HEADERS = g711common.h mgcp_transcode.h
diff --git a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
index 6b72965..8c3808a 100644
--- a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
+++ b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c
@@ -50,7 +50,7 @@
 #include "../../bscconfig.h"
 
 #ifdef BUILD_MGCP_TRANSCODING
-#include "mgcp_transcode.h"
+#include "openbsc/mgcp_transcode.h"
 #endif
 
 /* this is here for the vty... it will never be called */
diff --git a/openbsc/tests/mgcp/Makefile.am b/openbsc/tests/mgcp/Makefile.am
index 81f28ae..2bc2da6 100644
--- a/openbsc/tests/mgcp/Makefile.am
+++ b/openbsc/tests/mgcp/Makefile.am
@@ -18,7 +18,7 @@ mgcp_test_LDADD = $(top_builddir)/src/libbsc/libbsc.a \
 		$(LIBOSMOCORE_LIBS) -lrt -lm $(LIBOSMOSCCP_LIBS) $(LIBOSMOVTY_LIBS) \
 		$(LIBRARY_DL)
 
-mgcp_transcoding_test_SOURCES = mgcp_transcoding_test.c $(top_builddir)/src/osmo-bsc_mgcp/mgcp_transcode.c
+mgcp_transcoding_test_SOURCES = mgcp_transcoding_test.c
 
 mgcp_transcoding_test_LDADD = \
 		$(top_builddir)/src/libbsc/libbsc.a \
diff --git a/openbsc/tests/mgcp/mgcp_transcoding_test.c b/openbsc/tests/mgcp/mgcp_transcoding_test.c
index e5da138..9ba2c4b 100644
--- a/openbsc/tests/mgcp/mgcp_transcoding_test.c
+++ b/openbsc/tests/mgcp/mgcp_transcoding_test.c
@@ -17,7 +17,7 @@
 #error "Requires MGCP transcoding enabled (see --enable-mgcp-transcoding)"
 #endif
 
-#include "src/osmo-bsc_mgcp/mgcp_transcode.h"
+#include "openbsc/mgcp_transcode.h"
 
 uint8_t *audio_frame_l16[] = {
 };
-- 
1.7.9.5

More information about the OpenBSC mailing list