[libosmocore PATCH 1/4] protocol/gsm_12_21.h: Add the Manufacturer Attribute ID O_REDUCEPOWER.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Mon May 19 13:44:00 UTC 2014


Hi Holger,

On Mon, May 19, 2014 at 01:49:27PM +0200, Holger Hans Peter Freyther wrote:
> On Mon, May 19, 2014 at 11:48:47AM +0200, Harald Welte wrote:
> 
> > Rename NM_ATT_O_REDUCEPOWER to NM_ATT_OSMO_REDUCEPOWER, which
> > makes it more clear that this is an osmcoom specific attribute.
> > 
> > Also, we cannot simply overload 0x01 as an already defined OML
> > attribute.  The problem is quite simple: When we use abis_nm_att_tlvdef
> > during the TLV parse, 0x01 will match to NM_ATT_ABIS_CHANNEL,
> > which is defined as { TLV_TYPE_FIXED, 3 }.
> 
> But we already do have overlap. At least between BS11 and ipaccess.
> How is it different from GSM to osmocom? 

Yes, this is not an issue as e.g. openbsc uses the tlv_def_patch()
function to merge the generic 12.21 ones with either the BS11 ones, or
the ip.access ones.  There is no overlapping in those respective sets.
You can of couse not merge all three of them.  During the patching, the
vendor-specific IEI can override a 12.21 IEI / TLV definition.  I think
Siemens has in some cases used TV where the spec says TV16 or vice
versa.

But even if it was the intention of the osmocom IEI to override the
NM_ATT_ABIS_CHANNEL, then the code would first have to create a patched
tlv definition table, and then use tlv_parse with that patched table,
rather than the pristine 12.21 one.

> We could argue that the vendor values should not be in the gsm enum
> but sit somewhere else?

That might be an option, but its a mere difference in style.  If they're
all in one large enum, one can at least see their values/ranges in one
spot.

> > I'm using 0xfe for the attribute, as 0xfe doesn't overlap with the IPA
> > specific attribues (and we might want to combine/merge the 12.21 plus
> > IPA plus osmocom spefici attributes)
> 
> typo(s). :)

my apologies. well, as long as people can unserstand what I read, I
don't really think it is the most useful way to use my time to re-read
everything in order to spot + fix them.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the OpenBSC mailing list