This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Tue, May 20, 2014 at 07:50:48AM +0200, Alvaro Neira Ayuso wrote:
> +static int send_oml_fom_ack_nack(int fd_unix, struct msgb *old_msg,
> + uint8_t cause, int is_manuf)
> +{
Separate this method into several ones.
* You have modeled oml_fom_ack_nack and instead of copying it you
should extend oml_fom_ack_nack to support your use case. The
differences are:
** Support com.ipacces and org.osmocom manufacturer type
** Be able to send the message through a different socket.
The first can be achieved by modifying the parameter in oml_send_msg
to get the manufacturer name that can be put. E.g. by having the
cstring.
The later can be done by separating message creation and sending.
Please do the re-work like this. And create seaprate patches for
the refactoring.
> +static int take_reduce_power(struct abis_om_fom_hdr *fom, int len)
> +{
> + rc = oml_tlv_parse(&tlv_out, fom->data,
> + len - sizeof(struct abis_om_fom_hdr));
plese use sizeof(*fom)
P