[PATCH 4/9] Add support for AMR frames to MNCC/RTP interface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Andreas Eversberg andreas at eversberg.eu
Sun May 4 09:17:53 UTC 2014


>>> i had that patch done already. (see attachment)
>> what was the message id?  I didn't see it.
> Could you please answer this one?
hi holger,

sorry, i did not express myself well enough. i meant that i already 
wrote the patch, but did not send it to the mailing list.
>> This lacks input validation. The code needs to check that the data
>> we read is within the bounds of the msgb and the data we write is within
>> the bounds too.
i added a check that limits the GSM frames to 33 octets (full speech). 
(AMR requires only 31 octets + 1 octet length indicator.) an MNCC 
message has much larger msgb allocation when received. see attachment.

best regards

andreas






More information about the OpenBSC mailing list