[PATCH 2/2 openggsn] gtp: fix endianness in teid field of GTPv0 header

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Fri Mar 21 03:15:57 UTC 2014


On Thu, Mar 20, 2014 at 10:00:54PM +0100, Holger Hans Peter Freyther wrote:
> On Thu, Mar 20, 2014 at 03:34:00PM +0100, pablo at gnumonks.org wrote:
> > From: Pablo Neira Ayuso <pablo at gnumonks.org>
> > 
> > This field needs to be in network byte order as well.
> > ---
> > The problem only shows up if you use sgsn and ggsn with different
> > endianess. If no objections, I'll push this to master.
> 
> Oh? Did you have a set-up where this actually happened? What do you
> think about having macros to "write" and "read" the tid/imsi/nsapi?

The problem also manifest with the gtp kernel module. Basically, the
uplink packets from osmo-ggsn doesn't convert teid to network byte
order. But downlink packets (going throught the gtp0 device) are
indeed using network byte order. I'll add this to the description as
well.

And OK, I'll add some static inline functions to wrap that code.

Thanks for the feedback.




More information about the OpenBSC mailing list