[PATCH] sms: Use gsm_7bit_decode_n() in sms_test().

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Tue Mar 11 07:28:34 UTC 2014


On Tue, Mar 11, 2014 at 11:21 AM, Holger Hans Peter Freyther
<holger at freyther.de> wrote:
> On Mon, Mar 10, 2014 at 08:22:00PM +0100, Alexander Chemeris wrote:
>
>> gsm_7bit_decode() is deprecated. Replace it with gsm_7bit_decode_n().
>
>>               /* Test legacy function (return value only) */
>>               if (!test_decode[i].ud_hdr_ind) {
>> -                     nchars = gsm_7bit_decode(result, test_decode[i].input,
>>                       printf("Legacy decode case %d: "
>
> This test, tests the semantic of the old function. The only way this
> is going to be removed is by removing the legacy function. :)

Oh, right! I didn't realize it's a test for the deprecated function.

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co




More information about the OpenBSC mailing list