[PATCH 3/6] sms: Rename gsm340_gen_tpdu() to gsm340_gen_sms_deliver_tpdu() to show that it generates SMS-DELIVER TPDU and is not a generic function.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Sun Mar 9 21:44:01 UTC 2014


On Sun, Mar 9, 2014 at 7:32 PM, Holger Hans Peter Freyther
<holger at freyther.de> wrote:
> On Sun, Mar 09, 2014 at 11:58:04AM +0100, Alexander Chemeris wrote:
>
>> From e961b4f5fee04911b1c1f87d1b6aef496002ea8c Mon Sep 17 00:00:00 2001
>> From: Alexander Chemeris <Alexander.Chemeris at gmail.com>
>> Date: Sat, 8 Mar 2014 23:54:28 +0100
>> Subject: [PATCH 3/6] sms: Rename gsm340_gen_tpdu() to
>>  gsm340_gen_sms_deliver_tpdu() to show that it generates
>>  SMS-DELIVER TPDU and is not a generic function.
>
> man git-commit(1):
> "Though not required, it’s a good idea to begin the commit message with
> a single short (less than 50 character) line summarizing the change,
> followed by a blank line and then a more thorough description. The text
> up to the first blank line in a commit message is treated as the commit
> title, and that title is used throughout Git. For example,
> git-format-patch(1) turns a commit into email, and it uses the title on
> the Subject line and the rest of the commit in the body."
>
> Please try to follow that.

Yes, i try, sometimes I fail.

>> +/* generate a msgb containing an 03.40 9.2.2.1 SMS-DELIVER TPDU derived from
>> + * struct gsm_sms, returns total size of TPDU */
>
> Why "an"? Isn't "a" correct here?

You're probably right. Though this is not the biggest mistake with
articles I did.

> Document that < 0 indicates error?

I'm improving step by step, focusing on most important changes first :)

> And the comment style is only for net/* ;)

Not sure I understand this comment?

> I have applied it anyway as the naming of the method appears to be a
> lot better.

Thanks!

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co




More information about the OpenBSC mailing list