[PATCH] sms: Rename gsm340_gen_oa() to gsm340_gen_address_field().

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Tue Mar 11 14:26:26 UTC 2014


On Mon, Mar 10, 2014 at 07:40:51PM +0100, Alexander Chemeris wrote:
> Good idea. An updated patch is attached.

> +/* DEPRECATED: use gsm340_gen_address_field() instead */
> +int gsm340_gen_oa(uint8_t *oa, unsigned int oa_len, uint8_t type,
> +	uint8_t plan, const char *number) OSMO_DEPRECATED("Use gsm340_gen_address_field() instead");

this comment doesn't really add any value. You are using OSMO_DEPRECTAED
but you do not directly/indirectly the header file defining it. In fact
gsm0411_smc.c fails to compile due this.





More information about the OpenBSC mailing list