[PATCH 2/6] sms_test: Do not crash on logging.

[Alexander Chemeris]

12 марта 2014 г. 22:18 пользователь <noselasd at fiane.dyndns.org> написал:
>
> On 03/12/2014 05:49 PM, Alexander Chemeris wrote:
>
>>>> +#include <osmocom/core/logging.h>
>>>> +
>>>> +struct log_info fake_log_info = {};
>>>> +
>>>>   struct test_case {
>>>>        const uint8_t *input;
>>>>        const uint16_t input_length;
>>>> @@ -278,6 +282,9 @@ int main(int argc, char** argv)
>>>>        int nchars;
>>>>        char result[256];
>>>>
>>>> +     /* Fake logging. */
>>>> +     osmo_init_logging(&fake_log_info);
>>>
>>>
>>> osmo_init_logging() is declared in include/osmocom/core/application.h
>>
>>
>> Fixed, thanks.
>>
>> I don't like this fact that in C it's possible to use a non-defined
>> function and it's just a warning.
>
>
> gcc and clang can error on it with the flag
> -Werror=implicit-function-declaration

Should we add this to our default Makefiles? Any opinions?

Please excuse typos. Written with a touchscreen keyboard.

--
Regards,
Alexander Chemeris
CEO/Founder Fairwaves LLC
https://fairwaves.co
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20140312/5ba2ebdc/attachment.htm>