[PATCH 2/6] sms_test: Do not crash on logging.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Wed Mar 12 16:49:52 UTC 2014


On Wed, Mar 12, 2014 at 8:09 PM, Daniel Willmann <dwillmann at sysmocom.de> wrote:
> Hello Alexander,
>
> On Fri, 2014-03-07 at 21:15, Alexander Chemeris wrote:
>> From 13d7321d553b920b4b66d4c7d8f6f20c82bc3459 Mon Sep 17 00:00:00 2001
>> From: Alexander Chemeris <Alexander.Chemeris at gmail.com>
>> Date: Fri, 7 Mar 2014 20:42:03 +0100
>> Subject: [PATCH 2/6] sms_test: Do not crash on logging.
>>
>> ---
>>  tests/sms/sms_test.c |    7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c
>> index 755b321..cd21e92 100644
>> --- a/tests/sms/sms_test.c
>> +++ b/tests/sms/sms_test.c
>> @@ -31,6 +31,10 @@
>>  #include <osmocom/core/msgb.h>
>>  #include <osmocom/core/utils.h>
>>
>> +#include <osmocom/core/logging.h>
>> +
>> +struct log_info fake_log_info = {};
>> +
>>  struct test_case {
>>       const uint8_t *input;
>>       const uint16_t input_length;
>> @@ -278,6 +282,9 @@ int main(int argc, char** argv)
>>       int nchars;
>>       char result[256];
>>
>> +     /* Fake logging. */
>> +     osmo_init_logging(&fake_log_info);
>
> osmo_init_logging() is declared in include/osmocom/core/application.h

Fixed, thanks.

I don't like this fact that in C it's possible to use a non-defined
function and it's just a warning.

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sms_test-Do-not-crash-on-logging.patch
Type: text/x-patch
Size: 1012 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20140312/92f8972f/attachment.bin>


More information about the OpenBSC mailing list