[PATCH] sms: Proper decoding and storage of SMS validity period.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Wed Mar 12 15:53:00 UTC 2014


On Wed, Mar 12, 2014 at 6:59 PM, Daniel Willmann <dwillmann at sysmocom.de> wrote:
> Hello Alexander,
>
> On Wed, 2014-03-12 at 01:44, Alexander Chemeris wrote:
>> I've updated the patch to rename gsm340_validity_period() to
>> gsm340_validity_period_2() and keep gsm340_validity_period() as a
>> deprecated broken implementation. This way we keep compatibility with
>> older OpenBSC versions without updating to a new libosmocore library.
>
> looks all fine except for the function name. Something more expressive
> would be nice - how about gsm340_validity_period_as_ts()?

I'm not sure "as_ts" is really more expressive,
gsm340_validity_period_unix_time() would be more expressive, but it's
also painfully long. I would suggest:
 - gsm340_validity_time()
 - gsm340_validity_period_decode()
 - leave as is

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co




More information about the OpenBSC mailing list