[PATCH] sms: Proper decoding and storage of SMS validity period.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Mon Mar 10 19:14:14 UTC 2014


Hi Daniel, Holger,

Have you had any luck reviewing this patchset (achemeris/sms-validity
branch in git)?

On Fri, Mar 7, 2014 at 8:11 PM, Alexander Chemeris
<alexander.chemeris at gmail.com> wrote:
> - Use time_t instead of abstract minutes to store validity time to make sure
> we support all possible values.
> - Return UNIX time from it to support both relative and absolute expire
> times.
> - Pass a current time to gsm340_validity_period() to compute the absolute
> expire time if a relative time is specified. What time is "current" is to b
> - We also introduce SMS_DEFAULT_VALIDITY_PERIOD macros to reduce number of
> magic values.
>
> PS This is a first patch of a series of patches which fix SMS validity time
> decoding. I'm cleaning the patch set and want to see if this patch is fine,
> as other patches rely on it.
>
> --
> Regards,
> Alexander Chemeris.
> CEO, Fairwaves, Inc. / ООО УмРадио
> https://fairwaves.co



-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc. / ООО УмРадио
https://fairwaves.co




More information about the OpenBSC mailing list