This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Sat, Feb 22, 2014 at 12:36:02AM +0100, Jacob Erlbeck wrote:
Dear Jacob,
let me publicly say I think you did great work. Going from the problem
description and proposal of just dropping frames you have read both the
code and the specification and came up with a way better solution.
I was about to merge your branch but noticed one thing.
> +/* Table 3.1 TS 04.08: Values of parameter S */
> +static const uint8_t tx_integer[] = {
> + 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14, 16, 20, 25, 32, 50,
> +};
...
> + for (i = 0; i < 15; i++) {
> + if (tx_integer[i] == T) {
I didn't have breakfast yet but I think ARRAY_SIZE(tx_integer) is 16 but
the last element is never looked at. Can you confirm/reject?