This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Wed, Jul 16, 2014 at 07:04:28PM +0200, Daniel Willmann wrote: Hi! as we have to move forward I will merge it. One comment in regard to the approach taken here. > +gprs_rlcmac_tbf *gprs_rlcmac_pdch::tbf_from_list_by_tfi(struct llist_head *tbf_list, uint8_t tfi, > + enum gprs_rlcmac_tbf_direction dir) > { > gprs_rlcmac_tbf *tbf; > > llist_for_each_entry(tbf, tbf_list, list) { > + OSMO_ASSERT(tbf->direction == dir); > + return tbf_from_list_by_tfi(&bts_data()->ul_tbfs, tfi, GPRS_RLCMAC_UL_TBF); > + return tbf_from_list_by_tfi(&bts_data()->dl_tbfs, tfi, GPRS_RLCMAC_DL_TBF); assert it on _entry_ into the ul_tbfs and dl_tbfs. If we only have one place where the list is manipulated we can easily pay the price on entry.