[PATCH] tlv/msgb: Be able to generate and parse TLV as used by LLDP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Peter Stuge peter at stuge.se
Thu Jul 10 12:03:43 UTC 2014


Holger Hans Peter Freyther wrote:
> +++ b/src/gsm/tlv_parser.c
> @@ -51,6 +51,25 @@ int tlv_parse_one(uint8_t *o_tag, uint16_t *o_len, const uint8_t **o_val,
>  		return 1;
>  	}
>  
> +	/*
> +	 * Check if this could be a T7L9V tag. Do it by
> +	 * shifting it to the right once. Note that this
> +	 * means that mixing T7L9V with other tags is not
> +	 * possible.

Why not explicitly specify to do this test for each tag?

Ie. leave the old function as-is, add a new function with the T7L9V
heuristic, and use the new function only at call sites where T7L9V
may actually be encountered.


//Peter




More information about the OpenBSC mailing list