[PATCH 1/5] mgcp/test: Only include conn_mode into test output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Fri Jan 31 10:34:38 UTC 2014


On Thu, Jan 30, 2014 at 09:01:32PM +0100, Jacob Erlbeck wrote:

hi jacob!

> This patch modifies this to print the output_enabled flags to stderr
> instead. The bits in conn_mode are shown as RECV, SEND, and LOOP.
> This does not reduce the significance of the test, since there is an
> assertion already that verifies the values of the output_enabled
> flags with respect to the conn_mode.

there is no occurrence of "LOOP" in the testcase (and it can't be
trigerred through mgcp anyway?).

> +				       endp->conn_mode & MGCP_CONN_LOOPBACK &
> +				       ~MGCP_CONN_RECV_SEND ?

Why the & ~MGCP_CONN_RECV_SEND?






More information about the OpenBSC mailing list