[PATCH 3/3] mgcp/test: Don't reset conn_mode between messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Thu Jan 16 15:50:41 UTC 2014


Currently, the conn_mode field is reset after it has been checked.

This patch disables this behaviour and only adds a mark (bit) to
detect modifications.

Sponsored-by: On-Waves ehf
---
 openbsc/tests/mgcp/mgcp_test.c  |    4 +---
 openbsc/tests/mgcp/mgcp_test.ok |    1 +
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/openbsc/tests/mgcp/mgcp_test.c b/openbsc/tests/mgcp/mgcp_test.c
index 1f11b1d..fa68867 100644
--- a/openbsc/tests/mgcp/mgcp_test.c
+++ b/openbsc/tests/mgcp/mgcp_test.c
@@ -416,9 +416,7 @@ static void test_messages(void)
 			endp->net_end.packet_duration_ms = -1;
 			endp->local_options.pkt_period_min = 0;
 			endp->local_options.pkt_period_max = 0;
-			endp->conn_mode = MGCP_CONN_NONE | CONN_UNMODIFIED;
-			endp->net_end.output_enabled = 0;
-			endp->bts_end.output_enabled = 0;
+			endp->conn_mode |= CONN_UNMODIFIED;
 		}
 
 
diff --git a/openbsc/tests/mgcp/mgcp_test.ok b/openbsc/tests/mgcp/mgcp_test.ok
index 3b645e6..fbe2566 100644
--- a/openbsc/tests/mgcp/mgcp_test.ok
+++ b/openbsc/tests/mgcp/mgcp_test.ok
@@ -21,6 +21,7 @@ Detected packet duration: 40
 Requested packetetization period: 20-20
 Connection mode: 1, BTS output enabled, NET output disabled
 Testing MDCX3
+Dummy packets: 1
 Packet duration not set
 Requested packetization period not set
 Connection mode not set
-- 
1.7.9.5





More information about the OpenBSC mailing list