[PATCH 1/3] mgcp: Disable output enabled on initialisation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Thu Jan 16 15:50:39 UTC 2014


Currently RTP output_enabled is set to 1 on initialisation, which
does not semantically match the initial value of conn_mode
(MGCP_CONN_NONE).

This patch changes this initial value to 0.

Sponsored-by: On-Waves ehf
---
 openbsc/src/libmgcp/mgcp_protocol.c |    2 +-
 openbsc/tests/mgcp/mgcp_test.ok     |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/openbsc/src/libmgcp/mgcp_protocol.c b/openbsc/src/libmgcp/mgcp_protocol.c
index 9996ba7..9055bdb 100644
--- a/openbsc/src/libmgcp/mgcp_protocol.c
+++ b/openbsc/src/libmgcp/mgcp_protocol.c
@@ -1258,7 +1258,7 @@ static void mgcp_rtp_end_reset(struct mgcp_rtp_end *end)
 	end->frames_per_packet  = 0; /* unknown */
 	end->packet_duration_ms = DEFAULT_RTP_AUDIO_PACKET_DURATION_MS;
 	end->rate               = DEFAULT_RTP_AUDIO_DEFAULT_RATE;
-	end->output_enabled	= 1;
+	end->output_enabled	= 0;
 }
 
 static void mgcp_rtp_end_init(struct mgcp_rtp_end *end)
diff --git a/openbsc/tests/mgcp/mgcp_test.ok b/openbsc/tests/mgcp/mgcp_test.ok
index 7e8aa5c..3b645e6 100644
--- a/openbsc/tests/mgcp/mgcp_test.ok
+++ b/openbsc/tests/mgcp/mgcp_test.ok
@@ -51,7 +51,7 @@ Connection mode: 2, BTS output disabled, NET output enabled
 Testing DLCX
 Detected packet duration: 20
 Requested packetization period not set
-Connection mode: 0, BTS output enabled, NET output enabled
+Connection mode: 0, BTS output disabled, NET output disabled
 Testing CRCX_ZYN
 Dummy packets: 1
 Packet duration not set
@@ -67,7 +67,7 @@ Testing RQNT2
 Testing DLCX
 Detected packet duration: 20
 Requested packetization period not set
-Connection mode: 0, BTS output enabled, NET output enabled
+Connection mode: 0, BTS output disabled, NET output disabled
 Testing CRCX
 Re-transmitting CRCX
 Testing RQNT1
-- 
1.7.9.5





More information about the OpenBSC mailing list