This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Tue, Jan 14, 2014 at 12:58:11PM +0100, Andreas Eversberg wrote: Good Evening Andreas, > The code was tested with osmobts-trx. What does that it mean? What was the result of the test? What was the content of the test. "I tested it" is a sentence without any content. ;) > The user of e1inp_ipa_bts_rsl_connect() (which is osmo-bts) must be > upgraded after applying the patch. okay. thanks for the patch. > - dev->site_id, dev->bts_id, dev->trx_id); > + dev->site_id, dev->bts_id, trx_nr); We have an inconsistency problem here. From a design point of view it is bad to have dev->trx_id and a way to pass in the trx_nr. We can't remove dev->trx_id as OpenBSC is using it. Why can't we have more than one instance of the ipaccess_unit structure? For the sysmoBTS 2050 the mac addresses might/will be different too. > + if (link->ofd->priv_nr >= E1INP_SIGN_RSL) > + trx_nr = link->ofd->priv_nr - E1INP_SIGN_RSL; > + e1i_ts = &link->line->ts[link->ofd->priv_nr-1]; Where does this difference come from? What are the alternatives to this patch? Can we copy the cfg.ipa fields into a per RSL line field and set the trx_id there before the first time we use it? holger