[PATCH 9/9] mgcp: Send RTP keepalive dummy packets to net

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Tue Jan 14 08:41:39 UTC 2014


On 13.01.2014 09:57, Holger Hans Peter Freyther wrote:
> On Tue, Jan 07, 2014 at 12:07:51PM +0100, Jacob Erlbeck wrote:
> 
>> +	for (i = 1; i < tcfg->number_endpoints; ++i) {
>> +		struct mgcp_endpoint *endp = &tcfg->endpoints[i];
>> +		if (endp->bts_end.output_enabled)
> 
> Shouldn't this code look at the connection mode? E.g. the output is
> enabled even in SEND_RECV mode and then we certainly don't need to
> send dummy packets?
> 

If (and only if) we can rely on incoming packets from any type of BTS
when SEND_RECV is used, we could optimize these few packets away.

Otherwise I'd rather check, whether packets have been sent to the net
since the last timeout and only send a keep alive packet if there were none.

Jacob




More information about the OpenBSC mailing list