[PATCH 3/9] mgcp/test: Test the connection mode parser

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Tue Jan 14 08:54:48 UTC 2014


On 13.01.2014 09:52, Holger Hans Peter Freyther wrote:
> On Tue, Jan 07, 2014 at 12:07:45PM +0100, Jacob Erlbeck wrote:
> 
>> +		endp->bts_end.output_enabled = 0;
>> +		endp->net_end.output_enabled = 0;
> 
> I am afraid that with the manipulation of internal state
> we move away from testing the real thing.

Hmm, that's unit testing mainly targeted at the MGCP parser. So I'm not
too concerned about that, as long as I keep away from the part of the
state that is really used by the parser and not only set as a side effect.

> I understand that you want to capture the effect of parsing the
> message once. What about assigning variables that are not within the
> scope of what libmgcp/ would normally use? This way we can be sure
> that a.) libmgcp set these variables and b.) they are what we wanted
> it to be set to?

That would be ok, what's about 42 or -1?

Jacob





More information about the OpenBSC mailing list