Making jolly/testing ready to be merged?

[Andreas Eversberg]

Holger Hans Peter Freyther wrote:
> I wanted to start with merging the Connection Failure Criteria code but
> I am confused about the conversion. When parsing the criteria value from
> from the VTY you divide by four and subtract (so 4 becomes 0). You ondo
> this when saving the config and patching it in the nanoBTS attribute
> array.
>
> Wouldn't it be more easy to not doing the conversion?
>   
dear holger,

the attribute "bts->si_common.cell_options.radio_link_timeout" is
defined in gsm_04_08.h of libosmocore:

struct gsm48_cell_options {
        uint8_t radio_link_timeout:4,
                 dtx:2,
                 pwrc:1,
                 spare:1;
} __attribute__ ((packed));

we need this conversion, since we also need "cell_options" for SI3 and
SI6. i just use this attribute (and convert it back), so i don't need to
add an extra attribute to "bts" structure.

regards,

andreas