[PATCH 1/4] Each BTS can be configured for speech support (other than GSM full rate)

[Andreas Eversberg]

Holger Hans Peter Freyther wrote:
> ** CID 1155311:  Dereference after null check  (FORWARD_NULL)                                  
> /src/libmsc/gsm_04_08.c: 1825 in gsm48_cc_rx_setup()                                           
>                                                                                                
> ** CID 1155312:  Dereference after null check  (FORWARD_NULL)                                  
> /src/libmsc/gsm_04_08.c: 1979 in gsm48_cc_rx_call_conf()           
hi holger,

in both functions is a check for conn and lchan not beeing NULL:

if (trans->conn && trans->conn->lchan)
setup.lchan_type = trans->conn->lchan->type;

the functions are called by gsm0408_rcv_cc(). from there i can see that
trans->conn->lchan is always set, so the if-condition above is not required.

regards,

andreas