[PATCH 5/8] agch/pch: Use PCH for AGCH msgs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Mon Feb 24 10:27:48 UTC 2014


On 24.02.2014 10:38, Jacob Erlbeck wrote:
> On 22.02.2014 09:08, Holger Hans Peter Freyther wrote:
>> On Sat, Feb 22, 2014 at 12:36:06AM +0100, Jacob Erlbeck wrote:
>>> This patch extends paging_gen_msg() by adding an output parameter
>>> is_empty that is true, if only a paging message with dummy entries
>>> has been placed into buffer.
> 
> I also would like to remove the paging_add_imm_ass() because IMO it
> doesn't make much sense any longer.

It's still needed in pcu_rx_data_req() (pcu_sock.c):

===
case PCU_IF_SAPI_PCH:
	if (msg_type == PCU_IF_MSG_PAG_REQ) {
		/* FIXME: Add function to schedule paging request.
		 * This might not be required, if PCU_IF_MSG_DATA_REQ
		 * is used instead. */
	} else {
		struct gsm_bts_role_bts *btsb = bts->role;
		paging_add_imm_ass(btsb->paging_state, data_req->data,
				data_req->len);
	}
break;
===

But I don't understand why it is done this way.

Jacob




More information about the OpenBSC mailing list