[PATCH 5/5] agch/pch: Put CCCH message generation into common

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Fri Feb 21 17:06:30 UTC 2014


Hi Holger,

in case you merge, please fix the length computation below:

On 21.02.2014 15:09, Jacob Erlbeck wrote:
> --- a/src/common/bts.c
> +++ b/src/common/bts.c
> +int bts_ccch_copy_msg(struct gsm_bts *bts, uint8_t *out_buf, struct gsm_time *gt,
> +		      int is_ag_res)
> +{
> +
> +	memcpy(out_buf, msgb_l3(msg), msgb_l3len(msg));
> +	rc = msg->len;
It's

  rc = msgb_l3len(msg);

which accidentally delivers the same value.

Thanks,

Jacob





More information about the OpenBSC mailing list