[PATCH 3/5] agch: Log error if BS_AG_BLKS_RES is != 1 in SI3

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Fri Feb 21 14:09:13 UTC 2014


Currently, the DSP is always configured with u8NbrOfAgch = 1 before
SYSINFO type 3 is received. Thus using a different value for
BS_AG_BLKS_RES may lead to inconsistencies and MS failing to receive
paging messages properly.

This patch adds a warning and error logging and should be reverted
when initialisation is done in proper order.

Sponsored-by: On-Waves ehf
---
 src/common/paging.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/common/paging.c b/src/common/paging.c
index cd1c370..7c71c6f 100644
--- a/src/common/paging.c
+++ b/src/common/paging.c
@@ -535,6 +535,12 @@ static int paging_signal_cbfn(unsigned int subsys, unsigned int signal, void *hd
 		struct paging_state *ps = btsb->paging_state;
 		struct gsm48_system_information_type_3 *si3 = (void *) bts->si_buf[SYSINFO_TYPE_3];
 
+#warning "TODO: Remove this when setting u8NbrOfAgch is implemented properly"
+		if (si3->control_channel_desc.bs_ag_blks_res != 1)
+			LOGP(DPAG, LOGL_ERROR,
+			     "Paging: BS_AG_BLKS_RES = %d != 1 not fully supported\n",
+			     si3->control_channel_desc.bs_ag_blks_res);
+
 		paging_si_update(ps, &si3->control_channel_desc);
 	}
 	return 0;
-- 
1.7.9.5





More information about the OpenBSC mailing list