[PATCH 20/33] l1sap: re-introduce a comment that was lost during l1sap merge

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Wed Aug 27 21:54:39 UTC 2014


---
 src/common/l1sap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index e9d815c..c631860 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -467,6 +467,8 @@ int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr, struct tlv_parsed *
 	LOGP(DL1P, LOGL_INFO, "activating channel chan_nr=%02x trx=%d\n",
 		chan_nr, trx->nr);
 
+	/* osmo-pcu calls this without a valid 'tp' parameter, so we
+	 * need to make sure ew don't crash here */
 	if (tp && TLVP_PRESENT(tp, GSM48_IE_CHANDESC_2) &&
 	    TLVP_LEN(tp, GSM48_IE_CHANDESC_2) >= sizeof(*cd)) {
 		cd = (struct gsm48_chan_desc *)
-- 
2.1.0





More information about the OpenBSC mailing list