[PATCH 15/33] l1sap: additional comments explaining l1sap changes in l1_if.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Wed Aug 27 21:54:34 UTC 2014


---
 src/osmo-bts-sysmo/l1_if.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index d4861e2..03e8a56 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -599,6 +599,7 @@ static uint8_t chan_nr_by_sapi(enum gsm_phys_chan_config pchan,
 		return 0;
 	}
 
+	/* not reached due to default case above */
 	return (cbits << 3) | u8Tn;
 }
 
@@ -1029,10 +1030,13 @@ static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_i
 	}
 
 	if (!chan_nr) {
+		/* message was handled by old code, not by L1SAP */
 		msgb_free(l1p_msg);
 		return rc;
 	}
 
+	/* if we proceed to this point, the message has to be handled via L1SAP */
+
 	/* get data pointer and length */
 	data = data_ind->msgUnitParam.u8Buffer;
 	len = data_ind->msgUnitParam.u8Size;
-- 
2.1.0





More information about the OpenBSC mailing list