[PATCH 04/33] l1sap: Split ph_data_req() into smaller parts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Thu Aug 28 13:23:49 UTC 2014


On Thu, Aug 28, 2014 at 01:54:38PM +0200, Holger Hans Peter Freyther wrote:
> On Wed, Aug 27, 2014 at 11:54:23PM +0200, Harald Welte wrote:
> > ... in an effort to avoid introducing new/more spaghetti code
> 
> thanks!

The other obvious candidate is the (now) long section at the beginning
of ph_data_req() that determines sapi/subch/blocknr from the link_id and
channel number.  However, given that all major patches in the series
touches the code, I decided to postpone that split until the series is
merged.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the OpenBSC mailing list