[PATCH] Add subscriber delete command

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Ruben Pollan meskio at sindominio.net
Sun Aug 31 22:11:01 UTC 2014


Quoting Holger Hans Peter Freyther (2014-08-31 05:42:56)
> On Sun, Aug 24, 2014 at 02:02:16PM -0500, Ruben Pollan wrote:
> 
> Hi!
> 
> > This patch comes from some needs of rhizmoatica. It looks good in our tests, but 
> > today it's my first time looking at openbsc code and I might miss something.
> 
> sorry, I intendted to reply right-away and then had to rush and
> dropped the ball. To make sure your feature continue to work you
> should definately add an end-to-end test.
> 
> There is one technical issue. The subscriber record is reference
> counted. So if you free the memory while someobody else is using
> it you will crash.
> 
> Third, for machine to machine interaction we have the control
> interface which already has a command to delete the subscriber.
> Please have a look at
> 
>  src/libmsc/ctrl_commands.c:set_subscriber_delete

It makes sense, I just fixed. The new patch comes in a following email.

Thanks for the review.

-- 
Ruben Pollan  | http://meskio.net/
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 My contact info: http://meskio.net/crypto.txt
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Nos vamos a Croatan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20140831/96864571/attachment.bin>


More information about the OpenBSC mailing list