[PATCH] bsc/mminfo: Patch timezone and DST in MM Info messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Wed Sep 18 14:30:25 UTC 2013


On Tue, Sep 17, 2013 at 01:59:29PM +0200, Jacob Erlbeck wrote:

Good Afternoon Jacob!


> +	if (bts->tz.override) {

	if (!bts->tz.override)
		return 0;


do you mind if I change the code to be like that?

> +		/* Convert tz.hr and tz.mn to units */

this could be a routine by itself (but not for now)? I didn't read
the spec so I don't understand this calculation. :)

> +		if (TLVP_PRESENT(&tp, GSM48_IE_UTC)) {
> +			LOGP(DMSC, LOGL_DEBUG, "Changing 'Local time zone' from 0x%02x to 0x%02x.\n", TLVP_VAL(&tp, GSM48_IE_UTC)[6], tzbsd);

we aim for line width of 80 chars. E.g. break after LOGL_DEBUG and after
the format string.


> + * (C) 2013 by Jacob Erlbeck <jerlbeck at sysmocom.de>

Copyright is with sysmocom s.f.m.c. GmbH, you are the author and deserve
credit for the code. I think something like the below is approriate:

(C) 2013 by sysmocom s.f.m.c. GmbH
Written by Jacob Erlbeck

> +static uint8_t gsm48_mm_info_nn_tzt[] = {
> +	0x05, 0x32, 0x45, 0x08, 0x80, 0x4f, 0x77, 0xeb,
> +     	0x1a, 0xb6, 0x97, 0xe7, 0x47, 0x31, 0x90, 0x61,
> +       	0x11, 0x02, 0x73, 0x00,

I will remove the leading whitespace here. :)

> +	struct gsm_network *net = talloc_zero(text_ctx, struct gsm_network);
> +	struct gsm_bts *bts = talloc_zero(text_ctx, struct gsm_bts);
> +	struct osmo_bsc_sccp_con *sccp_con = talloc_zero(text_ctx, struct osmo_bsc_sccp_con);
> +	struct osmo_msc_data *msc = talloc_zero(text_ctx, struct osmo_msc_data);
> +	struct gsm_subscriber_connection *conn = talloc_zero(text_ctx, struct gsm_subscriber_connection);


if you put bts, sccp_con, msc and conn into the net context you can
do a talloc_free(net) and all the others will be freed. This way we
can run the test with valgrinds leak-check and get less output. :)


thank you very much for the change. I can make the modifications if
you agree in principle.

	holger




More information about the OpenBSC mailing list