[PATCH 2/4] vty: Hide unconfigured BTS on 'write'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Thu Sep 12 08:42:55 UTC 2013


On 09/12/2013 05:23 AM, Peter Stuge wrote:
> 
> My personal taste is to test all required conditions and exit early
> if they aren't met.
> 
> That way, it's easy to get an overview of all conditions, before the
> "meat" of the function takes place. It also avoids one level of
> nesting for each condition. The patch would in this case become quite
> simple:
> 
> +    if (!bts->model)
> +        return;
> 
> (Maybe even if (!bts || !bts->model) ..)

I agree, that's much better. Thanks for looking into it.

Jacob





More information about the OpenBSC mailing list