[PATCH 2/4] vty: Generalize ournode_exit() and ournode_end()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Mon Sep 2 18:24:45 UTC 2013


On Mon, Sep 02, 2013 at 01:17:15PM +0200, Jacob Erlbeck wrote:

Dear Jacob,

thanks a lot for the updated patch! I have applied this patch
locally (and updated the osmo-python-tests installation).


> +	if (vty->node >= CONFIG_NODE) {

as discussed in the office, I have replaced this with "> ENABLE_NODE". Can
you please double check tomorrow if I have done that correctly?


> +		/* Repeatedly call go_parent until a top node is reached. */
> +		while (vty->node > CONFIG_NODE) {
> +			if (vty->node == last_node) {

Shall we attempt to print a LOGL_ERROR if that happens? E.g. we would jump
from the loop to the enable node.





More information about the OpenBSC mailing list