[PATCH 4/5] msc: Do not store received id in the SMS database.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Tue Oct 8 10:08:13 UTC 2013


On Tue, Oct 8, 2013 at 12:03 PM, Holger Hans Peter Freyther
<holger at freyther.de> wrote:
> On Tue, Oct 08, 2013 at 03:17:32AM +0200, Alexander Chemeris wrote:
>> That was a bad idea from the very beginning. A visible result of this is a wrong
>> SMS routing when you change subscriber extensions, while having queued SMS. It's
>> also a very wrong thing from the code layering perspective.
>>
>> I think the next logical step should be to remove "receiver" pointer from
>> the gsm_sms structure into a structure, special for the internal SMS queue.
>
> how much extra effort is it to remove ->receiver right now?

We should create a new structure, new functions to
create/free/populate it, and translate sms_queue.c to using it.

I think about a day of work for me. A bit more, than I could afford
right now, unfortunately. :( May be a good task for someone who wants
to contribute and doesn't know where to start.

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves LLC / ООО УмРадио
http://fairwaves.ru




More information about the OpenBSC mailing list